Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Plan metadata #247

Merged
merged 5 commits into from
Oct 3, 2016
Merged

Add Plan metadata #247

merged 5 commits into from
Oct 3, 2016

Conversation

obates
Copy link
Contributor

@obates obates commented Mar 16, 2016

No description provided.

@jtauber jtauber modified the milestone: post-16.07 Jul 28, 2016
@paltman
Copy link
Contributor

paltman commented Jul 28, 2016

@obates can you look into and fix the Travis failure

@Brobin
Copy link
Contributor

Brobin commented Aug 11, 2016

Looks like a missing migration @obates , run python manage.py makemigrations

paltman
paltman requested changes Sep 18, 2016
View reviewed changes
Copy link
Contributor

@paltman paltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to merge this but we need migrations (python makemigrations.py) as well as a couple tests would be good (what happens if plan["metadata"] is None or other possibilities from the API.

@paltman paltman merged commit 8b8b6d5 into pinax:master Oct 3, 2016
@paltman
Copy link
Contributor

paltman commented Oct 3, 2016

I went ahead and added the migration. Thanks @obates!

@ticosax ticosax mentioned this pull request Oct 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paltman paltman paltman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-16.07
Development

Successfully merging this pull request may close these issues.
4 participants
@obates @paltman @Brobin @jtauber